Warning

• These commits modify unsafe code. Please review it carefully!

@steveklabnik Thanks for getting started on this! Another item to add to the list: renaming other uses of fail in function and parameter names. This is less important, but it'd be good to do and probably easiest as part of the same pass.

I am unsure of the changes in libcollections/vec.rs, I think that's talking about panic? But not 100% sure.

Whew, rebased. That sucked.

Everything in vec looks good to me

@aturon i'm guessing that that would be 'deprecate and make a new one'? Like the slice_or_fail methods in libcollections, for example?

Unsure how to rephrase

//! The core library cannot define failure, but it does *declare* failure. This

I guess libcore's failure isn't really the same thing? it's like, hardcore failure, right?

(speaking of src/libcore/failure.rs specifically)

checking off libsemver because it's already in an external crate

same for all the other ones which were moved out

@steveklabnik

@aturon i'm guessing that that would be 'deprecate and make a new one'? Like the slice_or_fail methods in libcollections, for example?

I'm not sure if something got lost in github, but it's not clear what this is referring to?

@steveklabnik

Unsure how to rephrase

   //! The core library cannot define failure, but it does *declare* failure. This

The "failure" here is referring to the implementation of fail!, so this should be talking about panicking instead (and the file should be renamed as well.)

Oh, and yes, it's fine to focus on doc comments and leave actual function/parameter names to API stabilization.

Yeah, I was talking about the method and parameter names.

Whew! Getting there! I've knocked out all the ones that have no messages, so the ones that left all need work.

aaaand rebased

This is amazing... please ping me on IRC when you're done and I'll try to do the final review quickly to avoid further rebasing pain.

No worries, after the rebase involving the removal of libdebug (imagine how many format strings went from {:?} to {}) it's not been that big of a deal :)

I'm guessing i'll be done in a day or two. been working on other stuff too since this is kind of mind-numbing.

std::task::failing should probably get re-named with the conventions update, @aturon

In the libcore stuff, I did change the name of the implementation of panic. I left the others alone though /cc @aturon

Okay! This is ready for a preliminary review, @aturon .

This may not currently compile, I haven't been able to test because I'm literally waiting for the internet to be installed in my new place within the next few hours, and I'm not going to download a snapshot over tethering 😉 I'll be able to double check that this actually works once that's set up.

This now compiles and stuff correctly. Woo!

OK, this looks basically good, but I've commented on a bunch of places where I think "fail" or "failure" is actually the right term.

After that, please squash down to a couple commits, and add a [breaking-change] marker along with instructions for how people should update their code.

Thanks again!